Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/268#issuecomment-65009386
Hi @babokim,
It's really great work. BTW, in my opinion, there are too many duplicated
classes in Thrift-based TajoCli. I think that it would be better if we reuse
TajoClient code. It could be easily possible if we change some protobuf classes
used by TajoClient uses to general Java classes. For it, we may need two
converter classes which is from protobuf to java classes and another is from
thrift to java classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
