Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/285#discussion_r21351579
  
    --- Diff: 
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
 ---
    @@ -823,6 +823,74 @@ public void createTable(final 
CatalogProtos.TableDescProto table) throws Catalog
       }
     
       @Override
    +  public void updateTableStats(final CatalogProtos.UpdateTableStatsProto 
statsProto) throws
    +    CatalogException {
    +    Connection conn = null;
    +    PreparedStatement pstmt = null;
    +    ResultSet res = null;
    +
    +    try {
    +      conn = getConnection();
    +      conn.setAutoCommit(false);
    +
    +      String[] splitted = 
CatalogUtil.splitTableName(statsProto.getTableName());
    +      if (splitted.length == 1) {
    +        throw new IllegalArgumentException("createTable() requires a 
qualified table name, but it is \""
    --- End diff --
    
    The exception message should be improved to print a proper function name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to