Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/286#discussion_r21439057
--- Diff:
tajo-core/src/main/java/org/apache/tajo/master/ha/HAServiceHDFSImpl.java ---
@@ -169,6 +173,48 @@ private void createMasterFile(boolean isActive) throws
IOException {
}
+ private String getHostName(String hostAddress, int type) {
+ String hostName = null;
+ int port = 0;
+
+ switch (type) {
+ case 1:
--- End diff --
I think that the direct use of number makes code readability bad. I'd like
to suggest using some constants or Enum type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
