[
https://issues.apache.org/jira/browse/TAJO-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238828#comment-14238828
]
ASF GitHub Bot commented on TAJO-1143:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/280#discussion_r21502424
--- Diff: tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java ---
@@ -278,6 +283,16 @@ private void checkAndInitializeSystemDirectories()
throws IOException {
LOG.info("Staging dir '" + stagingPath + "' is created");
}
}
+
+ private void evaluatePredefinedRules() throws EvaluationFailedException {
--- End diff --
In my opinion, using predefined rules seem to be general. I'd like to
recommend doSelfDiagnosis(), diagnoseSystem(), or diagnoseTajoMaster. It's just
a suggestion :) Similarly, we may be need to rethink the names in TajoClient
and TajoWorker.
> TajoMaster, TajoWorker, and TajoClient should have diagnosis phase at startup
> -----------------------------------------------------------------------------
>
> Key: TAJO-1143
> URL: https://issues.apache.org/jira/browse/TAJO-1143
> Project: Tajo
> Issue Type: Improvement
> Components: client, query master, tajo master
> Reporter: Hyunsik Choi
> Assignee: Jihun Kang
> Fix For: 0.9.1
>
>
> I propose that all cluster components (TajoMaster, TajoWorker, and
> TajoClient) in a Tajo cluster should have a diagnosis phase to eliminate or
> detect invalid situations prior to runtime query errors.
> For example, your query can cause some runtime exception due to wrong config
> after a query takes 2 hours. This situation is definitely not acceptable in
> production.
> I think that the diagnosis phase should check all configs, connectivities
> among cluster components, and status of workers.
> In detail, we need a diagnosis executor, extensible diagnosis rule interface,
> and its rules. Also, one of diagnosis rules would be TAJO-1114.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
