[
https://issues.apache.org/jira/browse/TAJO-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241337#comment-14241337
]
ASF GitHub Bot commented on TAJO-1233:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/288#issuecomment-66479977
Hi @babokim,
I really appreciate your contribution. It's really great work. This work
also includes the beginning of generic storage plugin. It's a nice starting
work.
I have one comment. In this patch, tajo-common/org.apache.tajo.json is
moved org.apache.tajo.storage.json. Although it's not related to the purpose of
this issue, this move touches lots of files. It's because GsonObject and
CommonGsonHelper are widely used in the system.
So, I'd like to suggest move back it to org.apache.tajo.json. If necessary,
we can do it in another jira.
Also, as I mentioned above, this patch needs rebase.
Thanks!
> Merge hbase_storage branch to the master branch
> -----------------------------------------------
>
> Key: TAJO-1233
> URL: https://issues.apache.org/jira/browse/TAJO-1233
> Project: Tajo
> Issue Type: Sub-task
> Components: storage
> Reporter: Hyoungjun Kim
> Assignee: Hyoungjun Kim
> Attachments: TAJO-1233.patch
>
>
> HBase Storage Integration issue (TAJO-1118) is completed. So hbase_storage
> branch should be merged to master branch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
