Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/312#discussion_r22146002
--- Diff:
tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
---
@@ -390,8 +392,8 @@ public synchronized void startQuery() {
optimizer.optimize(queryContext, plan);
- GlobalEngine.DistributedQueryHookManager hookManager = new
GlobalEngine.DistributedQueryHookManager();
- hookManager.addHook(new GlobalEngine.InsertHook());
+ DistributedQueryHookManager hookManager = new
DistributedQueryHookManager();
+ hookManager.addHook(new InsertIntoHook());
--- End diff --
Both QueryExecutor and QueryMasterTask have the DistributedQueryHookManager.
So, it would be better to maintain it in only one module.
Since this is not a big change, I think that we can fix this in this issue.
IMHO, QueryMasterTask is the proper one.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
