[
https://issues.apache.org/jira/browse/TAJO-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255451#comment-14255451
]
ASF GitHub Bot commented on TAJO-920:
-------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/308#issuecomment-67804082
Hi @sirpkt ,
+1
The patch looks good to me. I have one suggestion. Each test method name
should have the prefix 'test'. For example, ```lastValue1``` should be
```testLastValue1```. It's trivial, so you can immediately commit the patch
after fixing them.
> Add FIRST_VALUE and LAST_VALUE window functions
> -----------------------------------------------
>
> Key: TAJO-920
> URL: https://issues.apache.org/jira/browse/TAJO-920
> Project: Tajo
> Issue Type: Sub-task
> Components: physical operator, planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Keuntae Park
> Fix For: window function, 0.10
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
