[
https://issues.apache.org/jira/browse/TAJO-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257932#comment-14257932
]
ASF GitHub Bot commented on TAJO-1265:
--------------------------------------
Github user sirpkt commented on the pull request:
https://github.com/apache/tajo/pull/315#issuecomment-68024356
I updated the patch as followings
- null handling bug fix in getPartialResult() of Min and Max
- getEmptyTuple() in DistinctGroupbySortAggregationExec.java is changed to
make Tuple according to the type of aggregation functions: currently, null
datum for min and max and 0 for other types.
- Test result is fixed as correct value
mvn clean install passed.
sum() and avg() also need to be changed to handle null differently from
non-null values.
I'll make another issue about sum() and avg().
> min(), max() does not handle null properly
> ------------------------------------------
>
> Key: TAJO-1265
> URL: https://issues.apache.org/jira/browse/TAJO-1265
> Project: Tajo
> Issue Type: Bug
> Reporter: Keuntae Park
> Assignee: Keuntae Park
> Priority: Minor
>
> In other DBs like oracle and postgreSQL,
> null is excluded from calculation of min() and max() value until there is no
> non-null value in the given column, in which case, it returns null.
> However, current implementation of Tajo considers null as
> 0 for int or long column, 0.0 for float or double column, or "" for text
> column.
> It needs to handle null value separately from non-null values in min() and
> max() calculation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
