[ 
https://issues.apache.org/jira/browse/TAJO-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hyunsik Choi reassigned TAJO-940:
---------------------------------

    Assignee: Hyunsik Choi

> Default null config for CSV file in StoreTableExec should be moved to 
> planning phase.
> -------------------------------------------------------------------------------------
>
>                 Key: TAJO-940
>                 URL: https://issues.apache.org/jira/browse/TAJO-940
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Minor
>             Fix For: 0.10
>
>
> For more clear code, the null config should be moved to the planning phase.
> {code:title="StoreTableExec.java"}
>  if (plan instanceof InsertNode) {
>       InsertNode createTableNode = (InsertNode) plan;
>       appender = 
> StorageManagerFactory.getStorageManager(context.getConf()).getAppender(meta,
>           createTableNode.getTableSchema(), lastFileName);
>     } else {
>       String nullChar = 
> context.getQueryContext().get(ConfVars.CSVFILE_NULL.varname, 
> ConfVars.CSVFILE_NULL.defaultVal);
>       meta.putOption(StorageConstants.CSVFILE_NULL, nullChar);
>       appender = 
> StorageManagerFactory.getStorageManager(context.getConf()).getAppender(meta, 
> outSchema,
>           lastFileName);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to