[ 
https://issues.apache.org/jira/browse/TAJO-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267400#comment-14267400
 ] 

ASF GitHub Bot commented on TAJO-1260:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/335#discussion_r22575086
  
    --- Diff: 
tajo-core/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java ---
    @@ -367,6 +364,59 @@ public void testCreateTablePartitionByColumn() throws 
IOException {
       }
     
       @Test
    +  public void testAlterTableAddPartition1() throws IOException {
    +    String sql = FileUtil.readTextFile(new 
File("src/test/resources/queries/default/alter_table_add_partition_1.sql"));
    --- End diff --
    
    could you use FileUtil.readTextFileFromResource instead of direct paths? 
Direct path can cause errors without setting a base directory.


> Add ALTER TABLE ADD/DROP PARTITION statement to parser
> ------------------------------------------------------
>
>                 Key: TAJO-1260
>                 URL: https://issues.apache.org/jira/browse/TAJO-1260
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: parser
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>
> I plan to implement ALTER TABLE ADD/DROP PARTITION statement stage by stage. 
> For the first time, I'll add the statement to parser.
> {code:title=Syntax|borderStyle=solid}
> ALTER TABLE table_name [IF NOT EXISTS] ADD PARTITION (key1 = 'val2', key2 = 
> 'val2', ...) [LOCATION 'partition_path_of_directory'];
> ALTER TABLE table_name [IF NOT EXISTS] DROP PARTITION (key1 = 'val2', key2 = 
> 'val2', ...)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to