[ 
https://issues.apache.org/jira/browse/TAJO-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14269401#comment-14269401
 ] 

Tajo QA commented on TAJO-1288:
-------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12690847/TAJO-1288_2.patch
  against master revision release-0.9.0-rc0-128-ga1e0328.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:green}+1 tests included.{color}  The patch appears to include 18 new 
or modified test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 166 new 
Findbugs (version 2.0.3) warnings.

    {color:red}-1 release audit.{color}  The applied patch generated 296 
release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in 
tajo-core tajo-dist.

Test results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/568//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/568//artifact/incubator-tajo/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/568//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/568//console

This message is automatically generated.

> Refactoring org.apache.tajo.master package
> ------------------------------------------
>
>                 Key: TAJO-1288
>                 URL: https://issues.apache.org/jira/browse/TAJO-1288
>             Project: Tajo
>          Issue Type: Improvement
>          Components: query master
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.10
>
>         Attachments: TAJO-1288.patch, TAJO-1288_2.patch, TAJO-1288_3.patch
>
>
> org.apache.tajo.master includes a mixed of classes for TajoMaster and 
> QueryMaster. It looks somewhat messy. This patch refactors them to be located 
> in a proper package. Especially, I did as follows:
>  * Move some classes to org.apache.tajo.querymaster
>  * Move org.apache.tajo.scheduler to org.apache.tajo.master.scheduler
>  * Move some classes in org.apache.tajo.master to tajo.apache.tajo.master.exec
>  * Move some classes in org.apache.tajo.master to org.apache.tajo.ha.
>  * Remove FragmentPair, ScheduledFetch, and QueryMasterRunner which are 
> unused.
>  * Move Abstract/Default TaskScheduler and TaskScheduler* to 
> org.apache.tajo.querymaster.
> This is just a move issue of classes. Now, nobody seems to be working on 
> these packages. So, I think that now is the change to refactor them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to