[jira] [Commented] (TAJO-527) Upgrade to Netty 4

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAJO-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270914#comment-14270914
 ] 

ASF GitHub Bot commented on TAJO-527:
-------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/311#discussion_r22711753
  
    --- Diff: tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java 
---
    @@ -116,34 +124,24 @@ public void connect(InetSocketAddress addr) throws 
ConnectTimeoutException {
         handleConnectionInternally(addr);
       }
     
    -  public boolean isConnected() {
    -    return getChannel().isConnected();
    +  public boolean isActive() {
    +    return getChannel().isActive();
       }
     
       public InetSocketAddress getRemoteAddress() {
    -    if (channelFuture == null || channelFuture.getChannel() == null) {
    +    if (channelFuture == null || channelFuture.channel() == null) {
           return null;
         }
    -    return (InetSocketAddress) 
channelFuture.getChannel().getRemoteAddress();
    +    return (InetSocketAddress) channelFuture.channel().remoteAddress();
       }
     
       public Channel getChannel() {
    -    return channelFuture.getChannel();
    +    return channelFuture.channel();
       }
     
       @Override
       public void close() {
    -    if(this.channelFuture != null && getChannel().isOpen()) {
    -      try {
    -        getChannel().close().awaitUninterruptibly();
    --- End diff --
    
    Could you explain  why does not need channel.close() ?


> Upgrade to Netty 4
> ------------------
>
>                 Key: TAJO-527
>                 URL: https://issues.apache.org/jira/browse/TAJO-527
>             Project: Tajo
>          Issue Type: Improvement
>          Components: rpc
>            Reporter: Hyunsik Choi
>            Assignee: Jihun Kang
>
> Currently, rpc package uses Netty 3. Netty 4 is more stable and will get 
> significant performance benefits. We need to upgrade Netty version to 4.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)