[ 
https://issues.apache.org/jira/browse/TAJO-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271078#comment-14271078
 ] 

Jihun Kang commented on TAJO-1293:
----------------------------------

[~cepiross], could you check testNetworkAddressValidator function in 
TestValidators class? A specified invalid hostname, '50000', should be removed 
and valid hostnames which start with numerics would be added in this test case.

> Tajo have to accept hostname beginning with digits.
> ---------------------------------------------------
>
>                 Key: TAJO-1293
>                 URL: https://issues.apache.org/jira/browse/TAJO-1293
>             Project: Tajo
>          Issue Type: Improvement
>    Affects Versions: 0.10
>            Reporter: Jinhang Choi
>            Priority: Minor
>         Attachments: TAJO-1293.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> After investigating hostname pattern rule in NetworkAddressValidator, I found 
> that Tajo do not allow hostname beginning with digits, e.g. 0.linewalks.local.
> Even though IETF RFC953 has a constraint of starting alphabet in hostname, 
> IETF RFC1123 lessens the limit by allowing fully numeric hostname to be 
> valid. Therefore, I suggest that Tajo should change hostname pattern rule 
> from "^[a-zA-Z][-a-zA-Z0-9\\\\._]+$" to "^[a-zA-Z0-9][-a-zA-Z0-9\\\\._]+$".
> {noformat}
> 2015-01-09 14:21:15,838 ERROR org.apache.tajo.master.TajoMaster: Validation 
> Test has been failed on tajo.master.umbilical-rpc.address. Actual value is 
> 0.linewalks.local:26001
> org.apache.tajo.rule.EvaluationFailedException: Validation Test has been 
> failed on tajo.master.umbilical-rpc.address. Actual value is 
> 0.linewalks.local:26001
>         at 
> org.apache.tajo.rule.SelfDiagnosisRuleSession.fireRules(SelfDiagnosisRuleSession.java:66)
>         at 
> org.apache.tajo.master.TajoMaster.diagnoseTajoMaster(TajoMaster.java:294)
>         at org.apache.tajo.master.TajoMaster.serviceInit(TajoMaster.java:173)
>         at 
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
>         at org.apache.tajo.master.TajoMaster.main(TajoMaster.java:587)
> Caused by: org.apache.tajo.validation.ConstraintViolationException: 
> ConstraintViolationException [0.linewalks.local:26001 is not a valid network 
> address representation.]
>         at 
> org.apache.tajo.rule.base.TajoConfValidationRule.evaluate(TajoConfValidationRule.java:81)
>         at 
> org.apache.tajo.rule.SelfDiagnosisRuleSession.fireRules(SelfDiagnosisRuleSession.java:63)
>         ... 4 more
> 2015-01-09 14:21:15,839 INFO org.apache.hadoop.service.AbstractService: 
> Service org.apache.tajo.master.TajoMaster failed in state INITED; cause: 
> org.apache.tajo.rule.EvaluationFailedException: Validation Test has been 
> failed on tajo.master.umbilical-rpc.address. Actual value is 
> 0.linewalks.local:26001
> org.apache.tajo.rule.EvaluationFailedException: Validation Test has been 
> failed on tajo.master.umbilical-rpc.address. Actual value is 
> 0.linewalks.local:26001
>         at 
> org.apache.tajo.rule.SelfDiagnosisRuleSession.fireRules(SelfDiagnosisRuleSession.java:66)
>         at 
> org.apache.tajo.master.TajoMaster.diagnoseTajoMaster(TajoMaster.java:294)
>         at org.apache.tajo.master.TajoMaster.serviceInit(TajoMaster.java:173)
>         at 
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
>         at org.apache.tajo.master.TajoMaster.main(TajoMaster.java:587)
> Caused by: org.apache.tajo.validation.ConstraintViolationException: 
> ConstraintViolationException [0.linewalks.local:26001 is not a valid network 
> address representation.]
>         at 
> org.apache.tajo.rule.base.TajoConfValidationRule.evaluate(TajoConfValidationRule.java:81)
>         at 
> org.apache.tajo.rule.SelfDiagnosisRuleSession.fireRules(SelfDiagnosisRuleSession.java:63)
>         ... 4 more
> 2015-01-09 14:21:15,942 INFO org.apache.tajo.master.TajoMaster: Tajo Master 
> main thread exiting
> 2015-01-09 14:21:15,942 FATAL org.apache.tajo.master.TajoMaster: Error 
> starting TajoMaster
> org.apache.tajo.rule.EvaluationFailedException: Validation Test has been 
> failed on tajo.master.umbilical-rpc.address. Actual value is 
> 0.linewalks.local:26001
>         at 
> org.apache.tajo.rule.SelfDiagnosisRuleSession.fireRules(SelfDiagnosisRuleSession.java:66)
>         at 
> org.apache.tajo.master.TajoMaster.diagnoseTajoMaster(TajoMaster.java:294)
>         at org.apache.tajo.master.TajoMaster.serviceInit(TajoMaster.java:173)
>         at 
> org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
>         at org.apache.tajo.master.TajoMaster.main(TajoMaster.java:587)
> Caused by: org.apache.tajo.validation.ConstraintViolationException: 
> ConstraintViolationException [0.linewalks.local:26001 is not a valid network 
> address representation.]
>         at 
> org.apache.tajo.rule.base.TajoConfValidationRule.evaluate(TajoConfValidationRule.java:81)
>         at 
> org.apache.tajo.rule.SelfDiagnosisRuleSession.fireRules(SelfDiagnosisRuleSession.java:63)
>         ... 4 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to