[ 
https://issues.apache.org/jira/browse/TAJO-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302910#comment-14302910
 ] 

ASF GitHub Bot commented on TAJO-1325:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/371#discussion_r23987652
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/querymaster/QueryMaster.java ---
    @@ -525,7 +524,13 @@ private void cleanExpiredFinishedQueryMasterTask(long 
expireTime) {
           synchronized(finishedQueryMasterTasks) {
             List<QueryId> expiredQueryIds = new ArrayList<QueryId>();
             for(Map.Entry<QueryId, QueryMasterTask> entry: 
finishedQueryMasterTasks.entrySet()) {
    -          if(entry.getValue().getStartTime() < expireTime) {
    +          long finishedTime = entry.getValue().getStartTime();
    --- End diff --
    
    Would you leave some comments?


> Invalid history cleaner timeout
> -------------------------------
>
>                 Key: TAJO-1325
>                 URL: https://issues.apache.org/jira/browse/TAJO-1325
>             Project: Tajo
>          Issue Type: Bug
>          Components: query master, worker
>    Affects Versions: 0.8.0, 0.9.0, 0.10
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>             Fix For: 0.10
>
>
> Currently, QueryMaster and Worker  is store the histories in memory and file. 
> and these will be removed. but memory cleaner incorrectly work. We should fix 
> it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to