[
https://issues.apache.org/jira/browse/TAJO-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312132#comment-14312132
]
ASF GitHub Bot commented on TAJO-1298:
--------------------------------------
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/378
TAJO-1298: Improve the printing message after an execution of an index
creation statement
In this issue, I improved the printing message after an index creation.
In addition, I changed the writing process of ```create index``` query to
exploit the result staging feature. Instead of directly writing the results in
the output directory, Tajo writes them in the staging the results and moves
them to the final output directory on the successful query execution.
The following is an example of the improved message.
```
default> create index l_orderkey_idx on lineitem (l_orderkey);
Progress: 0%, response time: 1.169 sec
Progress: 0%, response time: 1.17 sec
...
Progress: 83%, response time: 17.446 sec
Progress: 100%, response time: 17.758 sec
(0 rows, 17.758 sec, 70.4 MiB inserted)
default>
```
As shown in this example, the number of inserted bytes represents the total
index size.
However, the number of rows is 0. I think this is right because index files
contain the binary information about the index structure, so the number of
inserted rows cannot be computed.
Alternatively, we can show the number of rows of source table instead of
the inserted number of rows.
In this case, I'm concerning the inconsistency of the printing messages.
What do you think?
Or, any other good idea?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1298
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #378
----
commit dafda3964dfd8f492b61506adf0e06f8a50dd28e
Author: Jihoon Son <[email protected]>
Date: 2015-02-03T09:44:00Z
TAJO-1298
commit 2de9f20fc553b6c227d898d156cca85dbcf6f151
Author: Jihoon Son <[email protected]>
Date: 2015-02-06T08:36:35Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into
TAJO-1298
commit e981ff419172f9a368304e16738a7e545cdb0b25
Author: Jihoon Son <[email protected]>
Date: 2015-02-09T05:38:27Z
TAJO-1298
commit edf464783401264e854e9356de658ec4e4b3ecec
Author: Jihoon Son <[email protected]>
Date: 2015-02-09T11:24:57Z
TAJO-1298
commit aa45f842146eb81c271a60d6fba4c97d61dc4a85
Author: Jihoon Son <[email protected]>
Date: 2015-02-09T11:26:46Z
TAJO-1298
commit 18824fe21beff7f677485750f932057a69f32613
Author: Jihoon Son <[email protected]>
Date: 2015-02-09T11:29:05Z
Merge branch 'index_support' of
https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1298
----
> Improve the printing message after an execution of an index creation statement
> ------------------------------------------------------------------------------
>
> Key: TAJO-1298
> URL: https://issues.apache.org/jira/browse/TAJO-1298
> Project: Tajo
> Issue Type: Sub-task
> Components: cli, index
> Reporter: Jihoon Son
> Assignee: Jihoon Son
> Priority: Minor
> Fix For: index support
>
>
> Currently, the result message of an index creation looks like that of a
> select query:
> {noformat}
> tpch> create index n_name_idx on nation (n_name);
> Progress: 100%, response time: 0.241 sec
> n_name
> -------------------------------
> (0 rows, 0.241 sec, 0 B selected)
> {noformat}
> We need to improve the message to be more helpful.
> In addition, various kinds of errors such as FileAlreadyExistsException
> should be handled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
