Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/403#issuecomment-78004394
Thank you for your contribution, I ran integer benchmark. but I found
performance decrement about 10%
I will upload the benchmark patch to jira. Can you check this ?
* Original
```
Result: 25611504.825 ±(99.9%) 126889.037 ops/s [Average]
Statistics: (min, avg, max) = (25290299.861, 25611504.825, 25869540.937),
stdev = 169393.233
Confidence interval (99.9%): [25484615.788, 25738393.861]
# Run complete. Total time: 00:01:02
Benchmark Mode Cnt Score
Error Units
BenchmarkNumberUtil.parseIntThroughput thrpt 25 29012506.326 ±
246843.623 ops/s
BenchmarkNumberUtil.unsafeParseIntThroughput thrpt 25 25611504.825 ±
126889.037 ops/s
```
* Applied your patch
```
Result: 22658219.224 ±(99.9%) 190563.440 ops/s [Average]
Statistics: (min, avg, max) = (22138484.562, 22658219.224, 23075760.439),
stdev = 254396.740
Confidence interval (99.9%): [22467655.784, 22848782.663]
# Run complete. Total time: 00:01:02
Benchmark Mode Cnt Score
Error Units
BenchmarkNumberUtil.parseIntThroughput thrpt 25 23777917.323 ±
157067.557 ops/s
BenchmarkNumberUtil.unsafeParseIntThroughput thrpt 25 22658219.224 ±
190563.440 ops/s
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
