[
https://issues.apache.org/jira/browse/TAJO-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354420#comment-14354420
]
ASF GitHub Bot commented on TAJO-1382:
--------------------------------------
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/403#issuecomment-78004394
Thank you for your contribution, I ran integer benchmark. but I found
performance decrement about 10%
I will upload the benchmark patch to jira. Can you check this ?
* Original
```
Result: 25611504.825 ±(99.9%) 126889.037 ops/s [Average]
Statistics: (min, avg, max) = (25290299.861, 25611504.825, 25869540.937),
stdev = 169393.233
Confidence interval (99.9%): [25484615.788, 25738393.861]
# Run complete. Total time: 00:01:02
Benchmark Mode Cnt Score
Error Units
BenchmarkNumberUtil.parseIntThroughput thrpt 25 29012506.326 ±
246843.623 ops/s
BenchmarkNumberUtil.unsafeParseIntThroughput thrpt 25 25611504.825 ±
126889.037 ops/s
```
* Applied your patch
```
Result: 22658219.224 ±(99.9%) 190563.440 ops/s [Average]
Statistics: (min, avg, max) = (22138484.562, 22658219.224, 23075760.439),
stdev = 254396.740
Confidence interval (99.9%): [22467655.784, 22848782.663]
# Run complete. Total time: 00:01:02
Benchmark Mode Cnt Score
Error Units
BenchmarkNumberUtil.parseIntThroughput thrpt 25 23777917.323 ±
157067.557 ops/s
BenchmarkNumberUtil.unsafeParseIntThroughput thrpt 25 22658219.224 ±
190563.440 ops/s
```
> Refactoring of NumberUtil to keep single copy of codes both for byte[] and
> bytebuf
> ----------------------------------------------------------------------------------
>
> Key: TAJO-1382
> URL: https://issues.apache.org/jira/browse/TAJO-1382
> Project: Tajo
> Issue Type: Improvement
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
>
> Another trivial patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
