[jira] [Commented] (TAJO-1301) Support CREATE INDEX [name] LOCATION [PATH] statement

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAJO-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356501#comment-14356501
 ] 

ASF GitHub Bot commented on TAJO-1301:
--------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/393#discussion_r26196142
  
    --- Diff: 
tajo-core/src/test/java/org/apache/tajo/engine/query/TestCreateIndex.java ---
    @@ -95,4 +95,19 @@ public final void testCreateIndexOnMultiExprs() throws 
Exception {
         assertFalse(catalog.existIndexByName(getCurrentDatabase(), 
"l_orderkey_100_l_linenumber_10_lt10_idx"));
         assertIndexNotExist(getCurrentDatabase(), 
"l_orderkey_100_l_linenumber_10_lt10_idx");
       }
    +
    +  @Test
    +  public final void testCreateIndexOnLocation() throws Exception {
    +    executeQuery();
    +    assertTrue(catalog.existIndexByName(getCurrentDatabase(), 
"l_orderkey_idx"));
    +    assertTrue(catalog.existIndexByColumnNames(getCurrentDatabase(), 
"lineitem", new String[]{"l_orderkey"}));
    +    catalog.dropIndex(getCurrentDatabase(), "l_orderkey_idx");
    +    assertFalse(catalog.existIndexByName(getCurrentDatabase(), 
"l_orderkey_idx"));
    +    executeString("create index l_orderkey_idx on lineitem (l_orderkey asc 
null first) location '/tajo/warehouse/default/l_orderkey_idx';");
    --- End diff --
    
    Could you check the title and test case?  syntax is difference


> Support CREATE INDEX [name] LOCATION [PATH] statement
> -----------------------------------------------------
>
>                 Key: TAJO-1301
>                 URL: https://issues.apache.org/jira/browse/TAJO-1301
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: index
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>            Priority: Minor
>             Fix For: index support
>
>         Attachments: TAJO-1301.patch
>
>
> See the title.
> This statement is required to support the index metadata backup and restore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)