[ 
https://issues.apache.org/jira/browse/TAJO-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357984#comment-14357984
 ] 

ASF GitHub Bot commented on TAJO-1383:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/404#discussion_r26273518
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/utils/TableCache.java ---
    @@ -0,0 +1,81 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.engine.utils;
    +
    +import com.google.common.collect.Lists;
    +import com.google.common.collect.Maps;
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.tajo.ExecutionBlockId;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +public class TableCache {
    --- End diff --
    
    Would you add some descriptions on this class?


> Improve broadcast table cache
> -----------------------------
>
>                 Key: TAJO-1383
>                 URL: https://issues.apache.org/jira/browse/TAJO-1383
>             Project: Tajo
>          Issue Type: Improvement
>          Components: physical operator
>    Affects Versions: 0.8.0, 0.9.0, 0.10
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>              Labels: performance
>         Attachments: TAJO-1383.patch
>
>
> Currently, broadcast implementation keep a tuples on scan operator and It 
> create a duplicated table cache in memory.
> We should improve it



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to