[
https://issues.apache.org/jira/browse/TAJO-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358715#comment-14358715
]
ASF GitHub Bot commented on TAJO-1391:
--------------------------------------
Github user ykrips commented on a diff in the pull request:
https://github.com/apache/tajo/pull/412#discussion_r26304267
--- Diff: tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
---
@@ -252,8 +257,11 @@ public void testConnectionFailed() throws Exception {
try {
int port = server.getListenAddress().getPort() + 1;
- client = new BlockingRpcClient(DummyProtocol.class,
- RpcUtils.getConnectAddress(new InetSocketAddress("127.0.0.1",
port)), retries);
+ RpcConnectionPool.RpcConnectionKey rpcConnectionKey =
+ new RpcConnectionPool.RpcConnectionKey(
+ RpcUtils.getConnectAddress(new
InetSocketAddress("127.0.0.1", port)),
+ DummyProtocol.class, false);
+ client = new BlockingRpcClient(rpcConnectionKey, retries);
--- End diff --
This code block does not throw ConnectException. how about add acquire
connection on this?
> RpcConnectionPool should check reference counter of connection before close
> ---------------------------------------------------------------------------
>
> Key: TAJO-1391
> URL: https://issues.apache.org/jira/browse/TAJO-1391
> Project: Tajo
> Issue Type: Improvement
> Components: rpc
> Reporter: Navis
> Assignee: Navis
>
> Connections in the pool is shared one and should be closed only when it's not
> referenced by other threads. Furthermore, current pool implementation locks
> whole connections for connecting/closing a connection, making bad
> interferences on other operations (on sane connection).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
