[
https://issues.apache.org/jira/browse/TAJO-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360192#comment-14360192
]
Jaehwa Jung edited comment on TAJO-1348 at 3/13/15 10:54 AM:
-------------------------------------------------------------
[~azuryy], thanks for your suggestion.
[~navis], thanks for your contribution.
Tajo defined SQL grammars to the SQLParser.g4 file. And it handle almost of
SQL parsing errors. If Tajo accept another class, such as, the SQLAnalyzer
class, there might be more considerations for the grammar file and the class.
But I found the asterisk in the file and related parse error implemented in the
class. MPOV, it seems to get away our principle of the grammar. If someone see
just the grammar file, he may misunderstand the grammar for creating table.
And if we don’t use the asterisk in the file, we need to add every case in the
file and related codes may be more complex in the class.
So, I think we’d better contain current grammar. What do you think about my
opinion?
For reference, please refer the pull request as follow:
https://github.com/apache/tajo/pull/398
was (Author: blrunner):
[~azuryy], thanks for your suggestion.
[~navis], thanks for your contribution.
Tajo defined SQL grammars to the SQLParser.g4 file. And it handle almost of
SQL parsing errors. If Tajo accept another class, such as, the SQLAnalyzer
class, there might be more considerations for the grammar file and the class.
But I found the asterisk in the file and related parse error implemented in the
class. MPOV, it seems to get away our principle of the grammar. If someone see
just the grammar file, he may misunderstand the grammar for creating table.
And if we don’t use the asterisk in the file, we need to add every case in the
file and related codes may be more complex in the class.
So, I think we’d better contain current grammar. What do you think about my
opinion?
> Parser error during create partitioned table
> --------------------------------------------
>
> Key: TAJO-1348
> URL: https://issues.apache.org/jira/browse/TAJO-1348
> Project: Tajo
> Issue Type: Bug
> Components: parser
> Affects Versions: 0.9.0
> Reporter: Fengdong Yu
> Assignee: Navis
>
> We must create partitioned table like this :
> create external table (a text, b text)
> USING RCFILE
> PARTITION BY COLUMN (dt text)
> LOCATION '/data/text;
> 'USING RCFILE' MUST place before 'PARTITION BY COLUMN', otherwise, Tajo
> complain 'ERROR: missing USING at 'PARTITION'
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
