Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/441#issuecomment-84378037
@navis your work is nice in overall. I left some comments.
Honestly, I'm writing tests to verify generated plans while working on
improving join ordering (https://issues.apache.org/jira/browse/TAJO-1352).
However, your test approach using the explain query looks better than mine. So,
I'd like to share some challenges which I met.
* Left and right children of a commutative join (inner and cross) are
interchangeable with each other. So, the plan can be changed.
* The order of shuffle keys between execution blocks can be changed.
These challenges should be addressed to validate query plans.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---