[
https://issues.apache.org/jira/browse/TAJO-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375898#comment-14375898
]
ASF GitHub Bot commented on TAJO-1436:
--------------------------------------
GitHub user navis opened a pull request:
https://github.com/apache/tajo/pull/456
TAJO-1436 Add Bind method to EvalNode
eval(Schema schema, Tuple tuple) --> bind(Schema schema) + eval(Tuple tuple)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/navis/tajo TAJO-1436
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #456
----
commit 65d68fd466e208f0eaaff973f862ae61dce873ee
Author: navis.ryu <[email protected]>
Date: 2015-03-23T13:42:11Z
TAJO-1436 Add Bind method to EvalNode
----
> Add Bind method to EvalNode
> ---------------------------
>
> Key: TAJO-1436
> URL: https://issues.apache.org/jira/browse/TAJO-1436
> Project: Tajo
> Issue Type: Improvement
> Components: operator/expression
> Reporter: Hyunsik Choi
> Assignee: Navis
> Fix For: 0.11.0
>
>
> EvalNode just has eval() method to evaluate some tuples. It does not have any
> method to prepare actual execution.
> For example, FieldEval should know an actual field index of an input tuple.
> This process is also performed in eval() method.
> It has some problems:
> * eval() method should involve two works, and it does different behavior
> with some flag or null check.
> * 'if condition' in eval() method for different behaviors involves
> unnecessary branches, causing performance degradation.
> So, we should add {{bind(Schema)}} method to EvalNode and then move some
> preparation code from eval() to bind(Schame) method.
> Also, we should refactor the signature {{eval(Schema, Tuple)}} to
> {{eval(Tuple)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
