[ 
https://issues.apache.org/jira/browse/TAJO-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386304#comment-14386304
 ] 

ASF GitHub Bot commented on TAJO-1469:
--------------------------------------

GitHub user navis opened a pull request:

    https://github.com/apache/tajo/pull/480

    TAJO-1469 allocateQueryMaster can leak resources if it times-out (3sec, 
hardcoded)

    Tested with some hack to reproduce timeout.
    ```java
    WorkerResourceAllocationResponse response = null;
    try {
      response = callFuture.get(3, queryInProgress.getQueryId().getSeq() < 3 ? 
TimeUnit.MICROSECONDS : TimeUnit.SECONDS);
    } catch (Throwable t) {
      ....
    }
    ```
    
    exceptions for first two but successes for all following queries.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navis/tajo TAJO-1469

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/480.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #480
    
----
commit 7700076e922a429b0ff5179052616c89afd5665d
Author: navis.ryu <[email protected]>
Date:   2015-03-30T07:06:08Z

    TAJO-1469 allocateQueryMaster can leak resources if it times-out (3sec, 
hardcoded)

----


> allocateQueryMaster can leak resources if it times-out (3sec, hardcoded)
> ------------------------------------------------------------------------
>
>                 Key: TAJO-1469
>                 URL: https://issues.apache.org/jira/browse/TAJO-1469
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: Navis
>            Assignee: Navis
>
> {code}
>     WorkerResourceAllocationResponse response = null;
>     try {
>       response = callFuture.get(3, TimeUnit.SECONDS);
>     } catch (Throwable t) {
>       LOG.error(t, t);
>       return null;
>     }
> {code}
> If it times-out (or interrupted), allocated resources cannot be retrieved 
> forever.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to