Github user babokim commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/474#discussion_r27559826
  
    --- Diff: 
tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java ---
    @@ -89,9 +89,9 @@ public TestJoinQuery(String joinOption) {
       @Parameters
       public static Collection<Object[]> generateParameters() {
         return Arrays.asList(new Object[][]{
    -        {"Hash_NoBroadcast"},
    --- End diff --
    
    These parameterized test cases should be included.
    Each query with different parameter returns different order of rows. Adding 
additional order by column or order by clause can resolve this problem as the 
following example:
    testComplexJoinCondition7.sql
    ```
    select
      n1.n_nationkey,
      n1.n_name,
      n2.n_name
    from nation n1 join (select * from nation union select * from nation) n2 on 
substr(n1.n_name, 1, 4) = substr(n2.n_name, 1, 4)
    order by n1.n_nationkey;
    ``` 
    
    You can add "n2.n_name" column in where clause.
    
    ```
    select
      n1.n_nationkey,
      n1.n_name,
      n2.n_name
    from nation n1 join (select * from nation union select * from nation) n2 on 
substr(n1.n_name, 1, 4) = substr(n2.n_name, 1, 4)
    order by n1.n_nationkey, n2.n_name;
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to