[jira] [Updated] (TAJO-1512) Fix various Expr cloning bugs

[Dongjoon Hyun (JIRA)]

     [ 
https://issues.apache.org/jira/browse/TAJO-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dongjoon Hyun updated TAJO-1512:
--------------------------------
    Description: 
When `Expr.clone()` is called, various 
errors(NPE/TypeCastingError/recursive/functional error) are occurs. This issue 
should be solved for others issues reusing `Expr`. Please refer the following 
code. 

* NPE case (Aggregation.java, UnaryOperator.java, CreateTable, AlterTable)
{code:java}
-    aggregation.namedExprs = new NamedExpr[namedExprs.length];
-    for (int i = 0; i < namedExprs.length; i++) {
-      aggregation.namedExprs[i] = (NamedExpr) namedExprs[i].clone();
+    if (namedExprs != null) {
+      aggregation.namedExprs = new NamedExpr[namedExprs.length];
+      for (int i = 0; i < namedExprs.length; i++) {
+        aggregation.namedExprs[i] = (NamedExpr) namedExprs[i].clone();
+      }
     }
 
-    aggregation.groups = new GroupElement[groups.length];
-    for (int i = 0; i < groups.length; i++) {
-      aggregation.groups[i] = (GroupElement) groups[i].clone();
+    if (groups != null) {
+      aggregation.groups = new GroupElement[groups.length];
+      for (int i = 0; i < groups.length; i++) {
+        aggregation.groups[i] = (GroupElement) groups[i].clone();
+      }
     }
{code}

{code:java}
-    alter.addNewColumn = (ColumnDefinition) addNewColumn.clone();
+    if (addNewColumn != null) {
+      alter.addNewColumn = (ColumnDefinition) addNewColumn.clone();
+    }
{code}

* Recursive (BetweenPredicate.java)
{code:java}
-    between.begin = (Expr) between.clone();
+    between.begin = (Expr) begin.clone();
{code}

* Type Casting Error (ValueListExpr.java)
{code:java}
-      valueListExpr.values = (Expr[]) values[i].clone();
+      valueListExpr.values[i] = (Expr) values[i].clone();
{code}

* Functional Error (CreateTable.java)
{code:java}
-      if (range.specifiers != null) {
+      if (specifiers != null) {
{code}

  was:
When `Expr.clone()` is called, NPE is raised because `Aggregation.clone()` does 
not check its `null` array. This issue should be solved for others issues 
reusing `Expr`. Please refer the following code. 

{code:java}
-    aggregation.namedExprs = new NamedExpr[namedExprs.length];
-    for (int i = 0; i < namedExprs.length; i++) {
-      aggregation.namedExprs[i] = (NamedExpr) namedExprs[i].clone();
+    if (namedExprs != null) {
+      aggregation.namedExprs = new NamedExpr[namedExprs.length];
+      for (int i = 0; i < namedExprs.length; i++) {
+        aggregation.namedExprs[i] = (NamedExpr) namedExprs[i].clone();
+      }
     }
 
-    aggregation.groups = new GroupElement[groups.length];
-    for (int i = 0; i < groups.length; i++) {
-      aggregation.groups[i] = (GroupElement) groups[i].clone();
+    if (groups != null) {
+      aggregation.groups = new GroupElement[groups.length];
+      for (int i = 0; i < groups.length; i++) {
+        aggregation.groups[i] = (GroupElement) groups[i].clone();
+      }
     }
{code}

        Summary: Fix various Expr cloning bugs  (was: Fix Aggregation.clone NPE 
bug)

> Fix various Expr cloning bugs
> -----------------------------
>
>                 Key: TAJO-1512
>                 URL: https://issues.apache.org/jira/browse/TAJO-1512
>             Project: Tajo
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Critical
>             Fix For: 0.10.1
>
>         Attachments: TAJO-1512.Hyun.150403.0.patch
>
>
> When `Expr.clone()` is called, various 
> errors(NPE/TypeCastingError/recursive/functional error) are occurs. This 
> issue should be solved for others issues reusing `Expr`. Please refer the 
> following code. 
> * NPE case (Aggregation.java, UnaryOperator.java, CreateTable, AlterTable)
> {code:java}
> -    aggregation.namedExprs = new NamedExpr[namedExprs.length];
> -    for (int i = 0; i < namedExprs.length; i++) {
> -      aggregation.namedExprs[i] = (NamedExpr) namedExprs[i].clone();
> +    if (namedExprs != null) {
> +      aggregation.namedExprs = new NamedExpr[namedExprs.length];
> +      for (int i = 0; i < namedExprs.length; i++) {
> +        aggregation.namedExprs[i] = (NamedExpr) namedExprs[i].clone();
> +      }
>      }
>  
> -    aggregation.groups = new GroupElement[groups.length];
> -    for (int i = 0; i < groups.length; i++) {
> -      aggregation.groups[i] = (GroupElement) groups[i].clone();
> +    if (groups != null) {
> +      aggregation.groups = new GroupElement[groups.length];
> +      for (int i = 0; i < groups.length; i++) {
> +        aggregation.groups[i] = (GroupElement) groups[i].clone();
> +      }
>      }
> {code}
> {code:java}
> -    alter.addNewColumn = (ColumnDefinition) addNewColumn.clone();
> +    if (addNewColumn != null) {
> +      alter.addNewColumn = (ColumnDefinition) addNewColumn.clone();
> +    }
> {code}
> * Recursive (BetweenPredicate.java)
> {code:java}
> -    between.begin = (Expr) between.clone();
> +    between.begin = (Expr) begin.clone();
> {code}
> * Type Casting Error (ValueListExpr.java)
> {code:java}
> -      valueListExpr.values = (Expr[]) values[i].clone();
> +      valueListExpr.values[i] = (Expr) values[i].clone();
> {code}
> * Functional Error (CreateTable.java)
> {code:java}
> -      if (range.specifiers != null) {
> +      if (specifiers != null) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)