[ 
https://issues.apache.org/jira/browse/TAJO-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395652#comment-14395652
 ] 

ASF GitHub Bot commented on TAJO-1462:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/475#discussion_r27768014
  
    --- Diff: tajo-docs/src/main/sphinx/table_management/text.rst ---
    @@ -34,19 +34,19 @@ Physical Properties
     Some table storage formats provide parameters for enabling or disabling 
features and adjusting physical parameters.
     The ``WITH`` clause in the CREATE TABLE statement allows users to set 
those parameters.
     
    -Now, the CSV storage format provides the following physical properties.
    +*TEXT* format provides the following physical properties.
     
     * ``text.delimiter``: delimiter character. ``|`` or ``\u0001`` is usually 
used, and the default field delimiter is ``|``.
    -* ``text.null``: NULL character. The default NULL character is an empty 
string ``''``. Hive's default NULL character is ``'\\N'``.
    +* ``text.null``: ``NULL`` character. The default ``NULL`` character is an 
empty string ``''``. Hive's default ``NULL`` character is ``'\\N'``.
     * ``compression.codec``: Compression codec. You can enable compression 
feature and set specified compression algorithm. The compression algorithm used 
to compress files. The compression codec name should be the fully qualified 
class name inherited from `org.apache.hadoop.io.compress.CompressionCodec 
<https://hadoop.apache.org/docs/current/api/org/apache/hadoop/io/compress/CompressionCodec.html>`_.
 By default, compression is disabled.
    -* ``csvfile.serde`` (deprecated): custom (De)serializer class. 
``org.apache.tajo.storage.TextSerializerDeserializer`` is the default 
(De)serializer class.
    +* ``text.serde``: custom (De)serializer class. 
``org.apache.tajo.storage.TextSerializerDeserializer`` is the default 
(De)serializer class.
    --- End diff --
    
    The default SerDe class is ```org.apache.tajo.storage.text.CSVLineSerDe```.


> Replace CSV examples into TEXT examples in docs
> -----------------------------------------------
>
>                 Key: TAJO-1462
>                 URL: https://issues.apache.org/jira/browse/TAJO-1462
>             Project: Tajo
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Trivial
>             Fix For: 0.10.1
>
>         Attachments: TAJO-1462.Hyun.150328.0.patch.txt, 
> TAJO-1462.Hyun.150331.0.patch.txt, TAJO-1462.Hyun.150331.1.patch.txt
>
>
> To guide users to move from CSV into TEXT storage type, this issue propose to 
> replace CSV examples into TEXT examples.
> * Case 1: An example with no delimiter definition
> {code:sql}
> - USING CSV
> + USING TEXT WITH ('textfile.delimiter'=',')
> {code}
> * Case 2: An example with text delimiter definition
> {code:sql}
> - USING CSV WITH('text.delimiter'='\u0001',...)
> + USING TEXT WITH('text.delimiter'='\u0001',...)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to