Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/439#issuecomment-89574266
Definitely, we should break a big problem into smaller ones if possible and
helpful.
IMO, this is not a case of the above one. You already break the big
problem, that is supporting grouping sets, into small ones including supporting
the syntax. I mean, we should do more important and core work first. I think
that this tradition is commonly shared by many development projects. When we
develop something, we first design the whole architecture, and then break it
into several modules. After that, we implement core modules first because
trivial modules are not anythings without the core ones.
On opening the legacy code, it may be helpful as you said. However, whether
the legacy code exists or not, we should adopt an efficient algorithm. To do
so, we should investigate many other projects and papers, and then discuss
them. This is one of the main reasons of using Jira.
Anyway, the performance of legacy code is not acceptable for practical
workloads. So, it wouldn't be helpful so much.
Finally, you can reuse the issue if you want. Please update the issue title
and description to be appropriate for the changed issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
