[ 
https://issues.apache.org/jira/browse/TAJO-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396146#comment-14396146
 ] 

ASF GitHub Bot commented on TAJO-1338:
--------------------------------------

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/490#issuecomment-89733757
  
    +1
    
    Great! It looks good overall to me and I found that rest server response 
successfully on my laptop as follows.
    ```
    $ curl -XGET 'http://localhost:26880/rest/databases'
    {"databases":["default","information_schema"]}
    
    $ curl -XGET 'http://localhost:26880/rest/databases/default/tables'
    
[{"tableName":"customer","external":true},{"tableName":"lineitem","external":true},{"tableName":"nation","external":true},{"tableName":"orders","external":true},{"tableName":"part","external":true},{"tableName":"partsupp","external":true},{"tableName":"supplier","external":true}]
    
    $  curl -XGET 'http://localhost:26880/rest/cluster'
    
{"workers":[{"connectionInfo":{"id":-2105400716,"host":"192.168.219.106","peerRpcPort":28091,"pullServerPort":64176,"queryMasterPort":28093,"clientPort":28092,"httpInfoPort":28080},"diskSlots":0.0,"cpuCoreSlots":1,"memoryMB":1024,"usedDiskSlots":0.0,"usedMemoryMB":0,"usedCpuCoreSlots":0,"maxHeap":932184064,"freeHeap":365067488,"totalHeap":458227712,"numRunningTasks":0,"numQueryMasterTasks":0,"lastHeartbeatTime":1428221077181}]}
    ```
    I leaved some trivial comments and I found unused methods in 
WorkerConnectionInfoResponse and WorkerResponse, too. Before you ship this, 
please check my comments. :)


> Defines RESTful API for Clients
> -------------------------------
>
>                 Key: TAJO-1338
>                 URL: https://issues.apache.org/jira/browse/TAJO-1338
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: client
>    Affects Versions: 0.11.0
>            Reporter: Jihun Kang
>            Assignee: Jihun Kang
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1338.patch, TAJO-1338_1.patch
>
>
> Based on RESTful implementations, RESTful API for clients will be created to 
> handle client requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to