[
https://issues.apache.org/jira/browse/TAJO-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396294#comment-14396294
]
ASF GitHub Bot commented on TAJO-1430:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/442#discussion_r27778444
--- Diff: tajo-core/src/main/java/org/apache/tajo/session/Session.java ---
@@ -121,6 +124,10 @@ public synchronized String getCurrentDatabase() {
return currentDatabase;
}
+ public synchronized void setQueryCache(LoadingCache<String, Expr> cache)
{ this.cache = cache; }
--- End diff --
The cache instance is always updated instead of adding a cache item to a
singleton cache instance. I don't think that this is a valid cache operation.
In addition, please follow our coding convention.
> Improve SQLAnalyzer by session-based parsing-result caching
> -----------------------------------------------------------
>
> Key: TAJO-1430
> URL: https://issues.apache.org/jira/browse/TAJO-1430
> Project: Tajo
> Issue Type: New Feature
> Components: parser
> Affects Versions: 0.10.0
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Fix For: 0.10.1
>
> Attachments: TAJO-1430.patch, long_2times.sql, wide_table.sql
>
>
> There are wide tables with many many columns. Moveover, BI tools generate
> very complex queries whose size is several MB. Although Tajo executes those
> queries very fast in a few seconds, the total time of UX is slow.
> To become a fastest Hadoop DW, we need this following feature.
> {code:sql}
> tsql -f long_2times.sql
> ...
> (0 rows, 30.641 sec, 0 B selected)
> ...
> (0 rows, 1.707 sec, 0 B selected)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
