Github user babokim commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/480#discussion_r27793934
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java
 ---
    @@ -221,11 +231,16 @@ public WorkerAllocatedResource 
allocateQueryMaster(QueryInProgress queryInProgre
         try {
           response = callFuture.get(3, TimeUnit.SECONDS);
         } catch (Throwable t) {
    -      LOG.error(t, t);
    -      return null;
    +      response = callFuture.cancel(); // try cancel
    +      if (response == null) {
    +        // canceled future
    +        LOG.warn("Got exception " + t);
    +        LOG.error(t, t);
    --- End diff --
    
    I think this line is not necessary if you change as the following in the 
immediately preceding line.
    ```
    LOG.warn("Got exception while allocating QueryMaster: " + t, t);  
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to