[ 
https://issues.apache.org/jira/browse/TAJO-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481193#comment-14481193
 ] 

ASF GitHub Bot commented on TAJO-1494:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/489#discussion_r27795762
  
    --- Diff: 
tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/FSDataInputChannel.java
 ---
    @@ -0,0 +1,67 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.tajo.storage;
    +
    +import org.apache.hadoop.fs.ByteBufferReadable;
    +import org.apache.hadoop.fs.FSDataInputStream;
    +import org.apache.hadoop.io.IOUtils;
    +
    +import java.io.IOException;
    +import java.nio.ByteBuffer;
    +import java.nio.channels.Channels;
    +import java.nio.channels.ReadableByteChannel;
    +
    +/**
    + * FSDataInputChannel is a NIO channel implementation of direct read 
ability to read from HDFS
    + */
    +public final class FSDataInputChannel extends InputChannel implements 
SeekableChannel {
    +
    +  private ReadableByteChannel channel;
    +  private FSDataInputStream inputStream;
    +  private boolean isDirectRead;
    +
    +  public FSDataInputChannel(FSDataInputStream inputStream) {
    +    if (inputStream.getWrappedStream() instanceof ByteBufferReadable) {
    --- End diff --
    
    O.K. Thanks for your feedback. 


> Add SeekableScanner support to DelimitedTextFileScanner
> -------------------------------------------------------
>
>                 Key: TAJO-1494
>                 URL: https://issues.apache.org/jira/browse/TAJO-1494
>             Project: Tajo
>          Issue Type: New Feature
>          Components: storage
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>         Attachments: TAJO-1494.patch, TAJO-1494_2.patch, TAJO-1494_3.patch
>
>
> CSVFile will be deprecated. So DelimitedTextFileScanner should support 
> SeekableScanner interface for BSTIndex



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to