[ 
https://issues.apache.org/jira/browse/TAJO-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482064#comment-14482064
 ] 

ASF GitHub Bot commented on TAJO-1430:
--------------------------------------

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/442#discussion_r27835860
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java 
---
    @@ -143,6 +148,18 @@ private QueryContext createQueryContext(Session 
session) {
           newQueryContext.putAll(CommonTestingUtil.getSessionVarsForTest());
         }
     
    +    // Set queryCache in session
    +    if (session.getQueryCache() == null) {
    +      session.setQueryCache(CacheBuilder.newBuilder()
    +        .maximumSize(200)
    --- End diff --
    
    That's a good idea. No problem. By the way, the weight should be estimated 
by SQL query string length, right? Or, do you have some Util to measure Expr 
memory consumption? Up to now, I can not find that kind of code in Expr. Do you 
think SQL query string length is okay?


> Improve SQLAnalyzer by session-based parsing-result caching
> -----------------------------------------------------------
>
>                 Key: TAJO-1430
>                 URL: https://issues.apache.org/jira/browse/TAJO-1430
>             Project: Tajo
>          Issue Type: New Feature
>          Components: parser
>    Affects Versions: 0.10.0
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>             Fix For: 0.10.1
>
>         Attachments: TAJO-1430.patch, long_2times.sql, wide_table.sql
>
>
> There are wide tables with many many columns. Moveover, BI tools generate 
> very complex queries whose size is several MB. Although Tajo executes those 
> queries very fast in a few seconds, the total time of UX is slow.
> To become a fastest Hadoop DW, we need this following feature. 
> {code:sql}
> tsql -f long_2times.sql
> ...
> (0 rows, 30.641 sec, 0 B selected)
> ...
> (0 rows, 1.707 sec, 0 B selected)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to