[ 
https://issues.apache.org/jira/browse/TAJO-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484582#comment-14484582
 ] 

Tajo QA commented on TAJO-1530:
-------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12723805/TAJO-1530.Hyun.150408.0.patch.txt
  against master revision release-0.9.0-rc0-245-ga1cf248.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:red}-1 tests included.{color}  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 17 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in 
tajo-core.

Test results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/725//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/725//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/725//console

This message is automatically generated.

> Display warn message when the query kill button is clicked in WEB UI.
> ---------------------------------------------------------------------
>
>                 Key: TAJO-1530
>                 URL: https://issues.apache.org/jira/browse/TAJO-1530
>             Project: Tajo
>          Issue Type: Improvement
>    Affects Versions: 0.10.0
>            Reporter: Hyoungjun Kim
>            Assignee: Dongjoon Hyun
>            Priority: Trivial
>         Attachments: TAJO-1530.Hyun.150408.0.patch.txt
>
>
> Currently If user click the 'kill query' button in WEB UI, the browser sends 
> immediately the kill request to TajoMaster. I think this is very dangerous 
> because user can click by mistake. 
> Tajo WEB UI should display warn message  when the query kill button is 
> clicked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to