[ 
https://issues.apache.org/jira/browse/TAJO-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484712#comment-14484712
 ] 

ASF GitHub Bot commented on TAJO-1505:
--------------------------------------

GitHub user navis opened a pull request:

    https://github.com/apache/tajo/pull/527

    TAJO-1505 Transferred plan should not include supplementary of FunctionDesc

    Considered to use node visitor, but seemed better not to modify internal 
shape of the plan. All modifications are just for doing,
    
    ```java
    @Override
    public FunctionSupplementProto getProto(SerializeOption option) {
      FunctionSupplementProto.Builder builder = 
FunctionSupplementProto.newBuilder();
      if (shortDescription != null && option != SerializeOption.INTERNAL) {
        builder.setShortDescription(shortDescription);
      }
      if (detail != null && option != SerializeOption.INTERNAL) {
        builder.setDetail(detail);
      }
      if (example != null && option != SerializeOption.INTERNAL) {
        builder.setExample(example);
      }
      return builder.build();
    }
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navis/tajo TAJO-1505

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #527
    
----
commit 91fd08e218662486f10303b1729dc20d4d505c6b
Author: navis.ryu <[email protected]>
Date:   2015-04-08T04:45:32Z

    TAJO-1505 Transferred plan should not include supplementary of FunctionDesc

----


> Transferred plan should not include supplementary of FunctionDesc.
> ------------------------------------------------------------------
>
>                 Key: TAJO-1505
>                 URL: https://issues.apache.org/jira/browse/TAJO-1505
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Assignee: Navis
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.11.0
>
>
> FunctionDesc consists of invocation description and supplement description. 
> Supplement description includes function examples and its documents.
> FunctionDesc is also used for serialized plan which is disseminated across a 
> number of cluster nodes for actual execution. But, supplementary description 
> is also included in serialized plans even though it is not necessary in 
> workers. For more efficient, Tajo should omit supplementary description when 
> it is transferred to workers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to