Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/442#discussion_r28203732
--- Diff: tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java ---
@@ -203,6 +203,7 @@ public static int setDateOrder(int dateOrder) {
// Query Configuration
QUERY_SESSION_TIMEOUT("tajo.query.session.timeout-sec", 60,
Validators.min("0")),
+ QUERY_SESSION_CACHE_SIZE("tajo.query.session.cache-size", 1000000,
Validators.min("1000000")),
--- End diff --
Oh, right. I meant 1MB not 1GB. According to your comment, it takes quite
long time to parse queries even though their size is a few KBs. So, I think
that KB is appropriate for the unit of size.
On minimum cache size, ```Validators.min("1000000")``` means that the cache
size under 1MB is an invalid value for this configuration. I think that you
didn't intend that, but if so, please tell me the reason.
On the cache on/off, your suggestion looks good. In addition to your
suggestion, it will be good if we can avoid checking the cache when the
configured cache size is 0. I think that this cache will not be used in many
cases because the cached data can be used only when the exactly same queries
are submitted repeatedly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
