Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/454#discussion_r28204015
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/function/window/CurrentValue.java
---
@@ -24,41 +24,34 @@
import org.apache.tajo.plan.function.WindowAggFunc;
import org.apache.tajo.storage.Tuple;
-public abstract class FirstValue extends WindowAggFunc<Datum> {
+public abstract class CurrentValue extends WindowAggFunc<Datum> {
- public FirstValue(Column[] columns) {
+ public CurrentValue(Column[] columns) {
super(columns);
}
@Override
public FunctionContext newContext() {
- return new FirstValueContext();
+ return new CurrentValueContext();
}
@Override
public void eval(FunctionContext ctx, Tuple params) {
- FirstValueContext firstValueCtx = (FirstValueContext)ctx;
- if(firstValueCtx.isSet == false) {
- firstValueCtx.isSet = true;
+ CurrentValueContext currentValueCtx = (CurrentValueContext)ctx;
if (params.get(0).isNotNull()) {
--- End diff --
This line seems to check whether ```params.get(0)``` is the ```NullDatum```
or not. In addition to this, we should check ```params.get(0)``` is actually
```null``` or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
