[
https://issues.apache.org/jira/browse/TAJO-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496107#comment-14496107
]
ASF GitHub Bot commented on TAJO-1497:
--------------------------------------
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/533#discussion_r28413814
--- Diff:
tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java ---
@@ -286,13 +286,13 @@ public void close() {
// remove session
NettyClientBase client = null;
try {
- client = connPool.getConnection(getTajoMasterAddr(),
TajoMasterClientProtocol.class, false);
+ client = manager.getConnection(getTajoMasterAddr(),
TajoMasterClientProtocol.class, false);
TajoMasterClientProtocolService.BlockingInterface tajoMaster =
client.getStub();
tajoMaster.removeSession(null, sessionId);
} catch (Throwable e) {
// ignore
} finally {
- connPool.releaseConnection(client);
+ manager.cleanup(client);
--- End diff --
Thank you for nice finding
> TajoClient does not share a connection
> --------------------------------------
>
> Key: TAJO-1497
> URL: https://issues.apache.org/jira/browse/TAJO-1497
> Project: Tajo
> Issue Type: Bug
> Components: client, rpc
> Affects Versions: 0.11.0
> Reporter: Jinho Kim
> Assignee: Jinho Kim
> Fix For: 0.11.0
>
> Attachments: TAJO-1497.patch, TAJO-1497_2.patch, TAJO-1497_3.patch
>
>
> Currently, tajo client try to connect per client API call.
> Because a client reference count is one. RPC pool should close only Idle
> connection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
