[
https://issues.apache.org/jira/browse/TAJO-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496318#comment-14496318
]
ASF GitHub Bot commented on TAJO-1497:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/533#discussion_r28428571
--- Diff:
tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java
---
@@ -33,17 +33,17 @@
protected Class<?> protocol;
protected boolean asyncMode;
protected boolean closeConn;
- protected RpcConnectionPool connPool;
+ protected RpcClientManager manager;
public abstract T call(NettyClientBase client) throws Exception;
- public ServerCallable(RpcConnectionPool connPool, InetSocketAddress
addr, Class<?> protocol, boolean asyncMode) {
+ public ServerCallable(RpcClientManager connPool, InetSocketAddress
addr, Class<?> protocol, boolean asyncMode) {
this(connPool, addr, protocol, asyncMode, false);
}
- public ServerCallable(RpcConnectionPool connPool, InetSocketAddress
addr, Class<?> protocol,
+ public ServerCallable(RpcClientManager manager, InetSocketAddress addr,
Class<?> protocol,
--- End diff --
This constructor seems to be not used anymore. How about removing it?
> RPC client does not share a connection
> --------------------------------------
>
> Key: TAJO-1497
> URL: https://issues.apache.org/jira/browse/TAJO-1497
> Project: Tajo
> Issue Type: Bug
> Components: client, rpc
> Affects Versions: 0.11.0
> Reporter: Jinho Kim
> Assignee: Jinho Kim
> Fix For: 0.11.0
>
> Attachments: TAJO-1497.patch, TAJO-1497_2.patch, TAJO-1497_3.patch
>
>
> Currently, tajo client try to connect per client API call.
> Because a client reference count is one. RPC pool should close only Idle
> connection
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
