Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/533#discussion_r28428571
--- Diff:
tajo-rpc/tajo-rpc-protobuf/src/main/java/org/apache/tajo/rpc/ServerCallable.java
---
@@ -33,17 +33,17 @@
protected Class<?> protocol;
protected boolean asyncMode;
protected boolean closeConn;
- protected RpcConnectionPool connPool;
+ protected RpcClientManager manager;
public abstract T call(NettyClientBase client) throws Exception;
- public ServerCallable(RpcConnectionPool connPool, InetSocketAddress
addr, Class<?> protocol, boolean asyncMode) {
+ public ServerCallable(RpcClientManager connPool, InetSocketAddress
addr, Class<?> protocol, boolean asyncMode) {
this(connPool, addr, protocol, asyncMode, false);
}
- public ServerCallable(RpcConnectionPool connPool, InetSocketAddress
addr, Class<?> protocol,
+ public ServerCallable(RpcClientManager manager, InetSocketAddress addr,
Class<?> protocol,
--- End diff --
This constructor seems to be not used anymore. How about removing it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
