[
https://issues.apache.org/jira/browse/TAJO-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499331#comment-14499331
]
ASF GitHub Bot commented on TAJO-1344:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/526#issuecomment-93902909
I leaved some trivial comments. The patch looks good to me. It's a great
job.
Here is my additional comments. You try to change the signature
EvalNode::bind to take EvalContext instance in order to get an instance of a
launched script engine.
Even though this refactoring is already a breaking change. EvalNode still
need more information about task. In this chance, it would be great if we
refactor EvalNode to take more meta context including TajoConf, task attempt
information, and shared resources of workers. Then, we can probably remove
OverridableConf parameter from all constructors of EvalNode.
If you are concerned with a large patch, we can do this work in another
jira. But, it will cause the second breaking change. We can choose either two
breaking change or a large patch. It's up to you.
> Python UDF support
> ------------------
>
> Key: TAJO-1344
> URL: https://issues.apache.org/jira/browse/TAJO-1344
> Project: Tajo
> Issue Type: New Feature
> Components: function/udf
> Reporter: Hyunsik Choi
> Assignee: Jihoon Son
> Fix For: 0.11.0
>
> Attachments: TAJO-1344.patch, TAJO-1344_2.patch, TAJO-1344_3.patch,
> TAJO-1344_4.patch, TAJO-1344_5.patch, TAJO-1344_6.patch, TAJO-1344_7.patch,
> TAJO-1344_8.patch
>
>
> Python has abundant users and third-party libraries. This language is widely
> used in data analytic area. So, it would be great if Tajo supports Python UDF.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
