[
https://issues.apache.org/jira/browse/TAJO-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502382#comment-14502382
]
ASF GitHub Bot commented on TAJO-1415:
--------------------------------------
Github user sirpkt commented on a diff in the pull request:
https://github.com/apache/tajo/pull/454#discussion_r28664862
--- Diff:
tajo-core/src/test/java/org/apache/tajo/engine/query/TestWindowQuery.java ---
@@ -462,4 +462,148 @@ public final void testMultipleWindow() throws
Exception {
executeString("DROP TABLE multiwindow PURGE");
}
}
+
+ @Test
+ public final void testWindowFrame1() throws Exception {
--- End diff --
You're right, @jihoonson.
I'll separate codes, queries, and results.
By the way, in other part of Tajo code,
there exists test codes like what I did (for example, testJoinQuery,
testJoinBroadcast, ...).
I think we need overall refactoring of test code to make them follow our
test writing convention.
> Window frame support
> --------------------
>
> Key: TAJO-1415
> URL: https://issues.apache.org/jira/browse/TAJO-1415
> Project: Tajo
> Issue Type: Sub-task
> Components: distributed query plan, parser, physical operator,
> planner/optimizer
> Reporter: Keuntae Park
> Assignee: Keuntae Park
> Fix For: window function
>
>
> We can define frame clause in window definition like
> {code}
> [ RANGE | ROWS ] frame_start
> [ RANGE | ROWS ] BETWEEN frame_start AND frame_end
> {code}
> , where frame_start and frame_end can be one of
> {code}
> UNBOUNDED PRECEDING
> value PRECEDING
> CURRENT ROW
> value FOLLOWING
> UNBOUNDED FOLLOWING
> {code}
> According to the window functions description of
> PostgreSQL(http://www.postgresql.org/docs/9.4/static/functions-window.html),
> there are two types of window functions based on window frame support.
> 1) row_number, rank, dense_rank, percent_rank, cume_dist, tile, lag and lead:
> these functions only work within window partition, which means window frame
> has no effect on these functions.
> 2) first_value, last_value, nth_value, and aggregation function as as window
> function: these functions should work with rows within window frame.
> Currently, Tajo parser recognize the window frame grammar but windowAggExec
> does not use that information.
> It works as if window frame is set as "RANGE BETWEEN UNBOUND PROCEEDING AND
> UNBOUNDED FOLLOWING", which is different from the default window frame
> setting of most DBMSs "RANGE BETWEEN UNBOUND PROCEEDING AND CURRENT ROW".
> Following should be done:
> 1) Applying correct default window frame for first_value, last_value,
> nth_value, and aggregation functions .
> 2) Supporting various window frame expressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
