[
https://issues.apache.org/jira/browse/TAJO-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514142#comment-14514142
]
ASF GitHub Bot commented on TAJO-1573:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/545#discussion_r29146506
--- Diff:
tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestSchema.java
---
@@ -147,13 +147,26 @@ public final void testGetColumnString() {
assertEquals(col3, schema.getColumn("addr"));
}
- @Test
- public final void testAddField() {
--- End diff --
This test looks to verify Schema.addColumn() with an unqualified column
name. Why don't you add a new test instead of modifying an existing test?
> Fix addColumn bug (fieldsByName should maintain a list per a simple field
> name)
> -------------------------------------------------------------------------------
>
> Key: TAJO-1573
> URL: https://issues.apache.org/jira/browse/TAJO-1573
> Project: Tajo
> Issue Type: Bug
> Affects Versions: 0.10.0
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Priority: Trivial
> Attachments: TAJO-1573.Hyun.150420.0.patch.txt,
> TAJO-1573.Hyun.150421.0.patch.txt
>
>
> In Schema.java, addColumn should maintain a column list per a simple field
> name. Currently, the maintained list has only the last appended one.
> {code}
> - fieldsByName.put(newCol.getSimpleName(), TUtil.newList(fields.size() -
> 1));
> + if (fieldsByName.containsKey(newCol.getSimpleName())) {
> + fieldsByName.get(newCol.getSimpleName()).add(fields.size() - 1);
> + } else {
> + fieldsByName.put(newCol.getSimpleName(), TUtil.newList(fields.size() -
> 1));
> + }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
