[
https://issues.apache.org/jira/browse/TAJO-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514154#comment-14514154
]
Tajo QA commented on TAJO-1563:
-------------------------------
{color:green}*+1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12728396/TAJO-1563_4.patch
against master revision release-0.9.0-rc0-275-gb50831f.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 6 new
or modified test files.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:green}+1 findbugs.{color} The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-client tajo-core tajo-rpc/tajo-rpc-common tajo-rpc/tajo-rpc-protobuf.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/762//testReport/
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/762//console
This message is automatically generated.
> Improve RPC error handling
> --------------------------
>
> Key: TAJO-1563
> URL: https://issues.apache.org/jira/browse/TAJO-1563
> Project: Tajo
> Issue Type: Improvement
> Components: query master, rpc, tajo master, worker
> Reporter: Jinho Kim
> Assignee: Jinho Kim
> Attachments: TAJO-1563.patch, TAJO-1563_2.patch, TAJO-1563_3.patch,
> TAJO-1563_4.patch
>
>
> Currently, RPC does not handle error for disconnection and a client does not
> throw if async RPC failed.
> for example. when a client calling and then it has lost a connection,
> callback has not been called.
> Callfuture.get() should throw ExecutionException and RPC client should handle
> a recoverable exception
> * Server internal exception handling
> ** Application exceptions
> *** send RemoteCallException to client
> ** Unexpected exceptions (Server failure)
> *** close current channel (client will receive channel inactive event)
> * Client internal exception handling
> ** Add internal retry when a stub is failed by connection lost
> ** Application exceptions
> *** throw exception to callback
> ** Max retry exceeded
> *** throw RecoverableException to internal exception handler
> ** Server hangs(server shutdown, OOM..)
> *** trigger the ping expired event. and throw ServiceException
> ** Unexpected exceptions (Client failure, connection lost)
> *** throw exception to all callback
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
