[ 
https://issues.apache.org/jira/browse/TAJO-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516711#comment-14516711
 ] 

ASF GitHub Bot commented on TAJO-1562:
--------------------------------------

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/551#issuecomment-96986771
  
    Great job! The interface looks nice to me. Even though some parts seem to 
need more optimization, it would take more time. I think that the current patch 
seems to be ready to be committed because the interface and the code skeleton 
are great. We can do more optimization later.
    
    I have one comment. Could you rename isUdf to others like isScalarFunction 
or isAggregationFunction? It would be more intuitive, I think.


> Python UDAF support
> -------------------
>
>                 Key: TAJO-1562
>                 URL: https://issues.apache.org/jira/browse/TAJO-1562
>             Project: Tajo
>          Issue Type: New Feature
>          Components: function/udf
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1562.patch
>
>
> We need to support Python UDAF as well as UDF (TAJO-1344). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to