[
https://issues.apache.org/jira/browse/TAJO-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516781#comment-14516781
]
ASF GitHub Bot commented on TAJO-1409:
--------------------------------------
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/430#issuecomment-97008145
If you set an error message in controller, Async {{CallFuture.get()}} can
throw exception.
like this example :
```
@Override
public void done(RpcController controller,
TajoWorkerProtocol.TaskCompletionReport report,
RpcCallback<PrimitiveProtos.BoolProto> done) {
try {
QueryMasterTask queryMasterTask = queryMaster.getQueryMasterTask(
new
QueryId(report.getId().getTaskId().getExecutionBlockId().getQueryId()));
if (queryMasterTask != null) {
queryMasterTask.getEventHandler().handle(new
TaskCompletionEvent(report));
}
done.run(TajoWorker.TRUE_PROTO);
} catch (Exception e) {
LOG.error(e.getMessage(), e);
controller.setFailed(e.getMessage());
done.run(TajoWorker.FALSE_PROTO);
}
}
```
> Clients calling remote services returning BoolProto ignores false values
> ------------------------------------------------------------------------
>
> Key: TAJO-1409
> URL: https://issues.apache.org/jira/browse/TAJO-1409
> Project: Tajo
> Issue Type: Improvement
> Components: rpc
> Reporter: Navis
> Assignee: Navis
>
> Some services like QueryMasterProtocolService returns false sometimes. But
> clients are just ignoring them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
