[ 
https://issues.apache.org/jira/browse/TAJO-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518713#comment-14518713
 ] 

ASF GitHub Bot commented on TAJO-1577:
--------------------------------------

GitHub user navis opened a pull request:

    https://github.com/apache/tajo/pull/558

    TAJO-1577 Add test cases to verify join plans

    @jihoonson Could you review this? If it's done in right way, I'll apply 
this to all tests in Test*JoinQuery

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/navis/tajo TAJO-1577

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #558
    
----
commit 97e31a9c6dc7bf327877b3959b3f56d0374bd58b
Author: navis.ryu <[email protected]>
Date:   2015-04-29T04:33:03Z

    TAJO-1577 Add test cases to verify join plans

----


> Add test cases to verify join plans
> -----------------------------------
>
>                 Key: TAJO-1577
>                 URL: https://issues.apache.org/jira/browse/TAJO-1577
>             Project: Tajo
>          Issue Type: Test
>          Components: test
>            Reporter: Jihoon Son
>             Fix For: 0.11.0
>
>
> We are lacking test cases to verify query plans even though they directly 
> affect to query processing performance. This is important especially for join 
> queries because their plans can be changed while optimizing join order that 
> affects to performance significantly. So, we need to verify the optimal join 
> plan first.
> There can be some approaches to test query plans. Here are some candidates 
> what I consider.
> * Adding a special class that verifies query plans while traversing it. 
> * Verifying the result of *EXPLAIN* query. 
> I think that the second approach looks good. Here are some reasons.
> * Easy to implement. It's just string match.
> * Easy to verify both logical plan and global plan without adding any special 
> classes to traverse query plan.
> * This is the most important reason. With the second approach, we can 
> guarantee that our query planner is deterministic. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to