[
https://issues.apache.org/jira/browse/TAJO-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519412#comment-14519412
]
ASF GitHub Bot commented on TAJO-1583:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/556#discussion_r29339908
--- Diff:
tajo-client/src/main/java/org/apache/tajo/client/SessionConnection.java ---
@@ -95,20 +96,29 @@ public SessionConnection(ServiceTracker tracker,
@Nullable String baseDatabase,
this.baseDatabase = baseDatabase != null ? baseDatabase : null;
this.serviceTracker = tracker;
+ try {
+ this.client = getTajoMasterConnection();
+ } catch (Exception e) {
+ throw new IOException(e);
+ }
}
public Map<String, String> getClientSideSessionVars() {
return Collections.unmodifiableMap(sessionVarsCache);
}
- public NettyClientBase getTajoMasterConnection(boolean asyncMode) throws
NoSuchMethodException,
- ConnectException, ClassNotFoundException {
- return manager.getClient(getTajoMasterAddr(),
TajoMasterClientProtocol.class, asyncMode);
- }
+ public synchronized NettyClientBase getTajoMasterConnection() throws
ServiceException {
--- End diff --
As I know, SessionConnection is created for each client. Do we need to
declare synchronized for this method?
> Remove ServerCallable in RPC client
> -----------------------------------
>
> Key: TAJO-1583
> URL: https://issues.apache.org/jira/browse/TAJO-1583
> Project: Tajo
> Issue Type: Task
> Components: client
> Reporter: Jinho Kim
> Assignee: Jinho Kim
> Priority: Minor
> Attachments: TAJO-1583.patch
>
>
> TAJO-1563 contains retry during invocation internally.
> We should remove it for more clearly. because it invoke repeatedly without
> reference to an application error
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
