Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/560#discussion_r29412956
--- Diff:
tajo-core/src/main/java/org/apache/tajo/ha/HdfsServiceTracker.java ---
@@ -70,12 +70,45 @@
public HdfsServiceTracker(TajoConf conf) throws IOException {
this.conf = conf;
+ }
+
+ @Override
+ public void register() throws IOException {
initSystemDirectory();
InetSocketAddress socketAddress =
conf.getSocketAddrVar(ConfVars.TAJO_MASTER_UMBILICAL_RPC_ADDRESS);
- this.masterName = socketAddress.getAddress().getHostAddress() + ":" +
socketAddress.getPort();
+ this.masterName = socketAddress.getAddress().getHostName()+ ":" +
socketAddress.getPort();
--- End diff --
Thanks for your review.
I also think that ip address would be more safety compare than host name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
