[
https://issues.apache.org/jira/browse/TAJO-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521201#comment-14521201
]
ASF GitHub Bot commented on TAJO-1584:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/559#discussion_r29414552
--- Diff:
tajo-core/src/main/java/org/apache/tajo/master/QueryInProgress.java ---
@@ -156,8 +161,15 @@ public boolean startQueryMaster() {
private void connectQueryMaster() throws Exception {
InetSocketAddress addr =
NetUtils.createSocketAddr(queryInfo.getQueryMasterHost(),
queryInfo.getQueryMasterPort());
LOG.info("Connect to QueryMaster:" + addr);
- queryMasterRpc =
- RpcClientManager.getInstance().getClient(addr,
QueryMasterProtocol.class, true);
+
+ /* A large scale cluster can be connection refused, if it reuse */
--- End diff --
It would be better if it should be changed to 'Connection can be refused in
large scale clusters if 'reuse' option is TRUE'.
In addition, this description should be also described in
```QUERY_MASTER_RPC_CLIENT_REUSE``` in TajoConf and user guide.
> Remove QueryMaster client sharing in TajoMaster and TajoWorker
> --------------------------------------------------------------
>
> Key: TAJO-1584
> URL: https://issues.apache.org/jira/browse/TAJO-1584
> Project: Tajo
> Issue Type: Improvement
> Components: multi tenancy, query master, rpc, tajo master, worker
> Reporter: Jinho Kim
> Assignee: Jinho Kim
> Attachments: TAJO-1584.patch, TAJO-1584_2.patch
>
>
> QueryMaster client should remove after use. It can possible that connection
> refused in very large cluster because too many open connections
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
